Skip to content

New error type #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jun 20, 2025
Merged

New error type #2500

merged 25 commits into from
Jun 20, 2025

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Jun 16, 2025

Now with 99% less enum cases. Add that to the cerial packaging as a selling point.

Closes #2469

@aumetra aumetra requested a review from chipshort June 16, 2025 13:43
@aumetra
Copy link
Member Author

aumetra commented Jun 16, 2025

Also the change on the shell files is very smol (just replacing /bin/bash with /usr/bin/env bash because if my NixOS install would've acted up one more time because of a missing interpreter, I would've gone insane)

@aumetra
Copy link
Member Author

aumetra commented Jun 17, 2025

Please I literally let the whole test suite run locally, how were these errors not caught
4x

@chipshort
Copy link
Collaborator

Please I literally let the whole test suite run locally, how were these errors not caught

Even the ./devtools/check_contracts_full.sh? Looks like what's failing are the contracts' integration tests.

@aumetra
Copy link
Member Author

aumetra commented Jun 17, 2025

Even the ./devtools/check_contracts_full.sh? Looks like what's failing are the contracts' integration tests.

Probably typo'd when executing. Taking care of it.

chipshort
chipshort reviewed Jun 17, 2025
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat that we can simplify the error type like that!

devtools/build_min.sh
#!/bin/bash
#!/usr/bin/env bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a fellow NixOS user (not on the work laptop though), I salute you 🫡

packages/std/src/errors/std_error.rs
Comment on lines +114 to +116
// "mom, can we have specialization?"
// "we have specialization at home"
// specialization at home:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

chipshort
chipshort reviewed Jun 17, 2025
View reviewed changes
aumetra and others added 11 commits June 17, 2025 16:47
@aumetra @chipshort
Update packages/crypto/testdata/extract_sig_gen.sh
2e7f8b8 
Co-authored-by: Christoph Otter <[email protected]>
@aumetra @chipshort
Update contracts/staking/src/state.rs
ebb6e57 
Co-authored-by: Christoph Otter <[email protected]>
@aumetra @chipshort
Update contracts/staking/src/state.rs
c68a5ce 
Co-authored-by: Christoph Otter <[email protected]>
@aumetra @chipshort
Update contracts/hackatom/src/contract.rs
21368f3 
Co-authored-by: Christoph Otter <[email protected]>
@aumetra @chipshort
Update contracts/hackatom/src/contract.rs
d10b4bc 
Co-authored-by: Christoph Otter <[email protected]>
@aumetra @chipshort
Update contracts/hackatom/src/contract.rs
fb99869 
Co-authored-by: Christoph Otter <[email protected]>
@aumetra @chipshort
Update contracts/ibc-callbacks/src/state.rs
e2c33a9 
Co-authored-by: Christoph Otter <[email protected]>
@aumetra @chipshort
Update contracts/reflect/src/state.rs
079bbf1 
Co-authored-by: Christoph Otter <[email protected]>
@aumetra @chipshort
Update contracts/reflect/src/state.rs
050445d 
Co-authored-by: Christoph Otter <[email protected]>
@aumetra
Format
34eacf2
@aumetra
thiserror compatibility
0d3a2a0
chipshort
chipshort reviewed Jun 18, 2025
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a changelog entry needed

chipshort
chipshort approved these changes Jun 20, 2025
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@chipshort chipshort merged commit f3ad156 into main Jun 20, 2025
42 checks passed
@chipshort chipshort deleted the aw/new-error branch June 20, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort chipshort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign StdError type
2 participants
@aumetra @chipshort